Upgrade API to 1.4 versions #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdwitr0
reviewed
Jan 22, 2024
src/core/builder/query-builder.ts
Outdated
| throw new Error(str); | ||
| } | ||
|
|
||
| private isDate(val: any) { |
Contributor
There was a problem hiding this comment.
метод называется Is Date, по идее должен проверять является ли значение датой, но это пропустит не валидную дату. Например new Date("ержан") вернет true. Если это используется только для сужения типов, то лучше вынести из класса.
* Upgrade QueryBuilder to class with methods, or just request types * Pass types to each service for QueryBuilder
mdwitr0
reviewed
Jan 27, 2024
| query.append(key, this.fixedEncodeURIComponent(String(val))); | ||
| }; | ||
| switch (queryBuilderField) { | ||
| case QueryBuilderFields.$ne: |
Contributor
There was a problem hiding this comment.
Вынеси в отдельный приватный метод весь switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.